Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61601779
The core changes look good to me, save for the one comment on
compatibility. I would rather not review the UI and JsonProtocol changes in
detail, though, as I am not so well acclimated to that code. One thing I
noticed from the screenshots, though, was that the height of the stack trace
box seems relatively small -- is it decided by the height of the cell prior to
expansion, or does it just have a small fixed height? We should probably add a
minimum height that's significantly larger to make the stack trace more
readable. I think we already do something similar for the other stack traces in
the UI.
@andrewor14 Would you mind reviewing the UI/JSON code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
