Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21789#discussion_r203665364
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -766,6 +774,14 @@ class HiveThriftHttpServerSuite extends
HiveThriftJdbcTest {
assert(resultSet.getString(2) === HiveUtils.builtinHiveVersion)
}
}
+
+ test("Checks cast as float") {
--- End diff --
yes, so if you add the test to `HiveThriftJdbcTest` it will be executed in
both in `HiveThriftBinaryServerSuite` and ` HiveThriftBinaryServerSuite`....
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
