Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21789#discussion_r203679349
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/Column.java ---
@@ -349,7 +349,7 @@ public void addValue(Type type, Object field) {
break;
case FLOAT_TYPE:
nulls.set(size, field == null);
- doubleVars()[size] = field == null ? 0 :
((Float)field).doubleValue();
+ doubleVars()[size] = field == null ? 0 : new
Double(field.toString());
--- End diff --
I see now the issue, so we cannot convert directly from float to double, we
have to pass through another object which may be a string as in this your
solution. Please disregard my comment, thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
