Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21822#discussion_r204163551
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -533,7 +537,8 @@ trait CheckAnalysis extends PredicateHelper {
// Simplify the predicates before validating any unsupported
correlation patterns
// in the plan.
- BooleanSimplification(sub).foreachUp {
+ // TODO(rxin): Why did this need to call BooleanSimplification???
--- End diff --
Yeah, I added boolean simplification here. I didn't quite like it back
then, and I still don't like it. I was hoping this was happening in the
`Optimizer` now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
