Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21822#discussion_r204167870
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -533,7 +537,8 @@ trait CheckAnalysis extends PredicateHelper {
// Simplify the predicates before validating any unsupported
correlation patterns
// in the plan.
- BooleanSimplification(sub).foreachUp {
+ // TODO(rxin): Why did this need to call BooleanSimplification???
--- End diff --
Well tests fail without it, so we don't really have a choice here. For a
second I thought we could also create some utils class, but that would just
mean moving the code in BooleanSimplification in there just for esthetics.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
