Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21721#discussion_r206373655
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala
 ---
    @@ -143,18 +151,46 @@ trait ProgressReporter extends Logging {
         }
         logDebug(s"Execution stats: $executionStats")
     
    +    // extracts custom metrics from readers and writers
    +    def extractMetrics(getMetrics: () => Option[CustomMetrics],
    +                      onInvalidMetrics: (Exception) => Unit): 
Option[JValue] = {
    --- End diff --
    
    nit:
    
    ```scala
    def extractMetrics(
        getMetrics: () => Option[CustomMetrics],
        onInvalidMetrics: (Exception) => Unit): Option[JValue] = {
    ```



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to