Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206726327
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming
+
+import org.apache.spark.internal.Logging
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.expressions.{Attribute, UnsafeRow}
+import
org.apache.spark.sql.catalyst.expressions.codegen.{GenerateUnsafeProjection,
GenerateUnsafeRowJoiner}
+import org.apache.spark.sql.execution.streaming.state.{StateStore,
UnsafeRowPair}
+import org.apache.spark.sql.types.StructType
+
+object StatefulOperatorsHelper {
+
+ val supportedVersions = Seq(1, 2)
+ val legacyVersion = 1
+
+ sealed trait StreamingAggregationStateManager extends Serializable {
+ def extractKey(row: InternalRow): UnsafeRow
+ def getValueExpressions: Seq[Attribute]
+ def restoreOriginRow(rowPair: UnsafeRowPair): UnsafeRow
--- End diff --
I dont think this method is needed if you rather add methods `getIterator`
and `remove` to this interface. The only reason `restoreOriginRow` this being
used is because the operator is directly accessing the `store` (through
`store.remove()` and `store.iterator()`) and then trying to fix the row,
instead of the delegating those operations to the `StateManager`. In fact, if
there exists a `StateManager` to manage all the state in the store, then ALL
operations to add/remove state should go through the manager and `store` should
not be accessed directly.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
