Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206781209
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming
+
+import org.apache.spark.internal.Logging
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.expressions.{Attribute, UnsafeRow}
+import
org.apache.spark.sql.catalyst.expressions.codegen.{GenerateUnsafeProjection,
GenerateUnsafeRowJoiner}
+import org.apache.spark.sql.execution.streaming.state.{StateStore,
UnsafeRowPair}
+import org.apache.spark.sql.types.StructType
+
+object StatefulOperatorsHelper {
+
+ val supportedVersions = Seq(1, 2)
+ val legacyVersion = 1
+
+ sealed trait StreamingAggregationStateManager extends Serializable {
+ def extractKey(row: InternalRow): UnsafeRow
+ def getValueExpressions: Seq[Attribute]
+ def restoreOriginRow(rowPair: UnsafeRowPair): UnsafeRow
+ def get(store: StateStore, key: UnsafeRow): UnsafeRow
+ def put(store: StateStore, row: UnsafeRow): Unit
+ }
+
+ object StreamingAggregationStateManager extends Logging {
+ def createStateManager(
+ keyExpressions: Seq[Attribute],
+ childOutput: Seq[Attribute],
+ stateFormatVersion: Int): StreamingAggregationStateManager = {
+ stateFormatVersion match {
+ case 1 => new
StreamingAggregationStateManagerImplV1(keyExpressions, childOutput)
+ case 2 => new
StreamingAggregationStateManagerImplV2(keyExpressions, childOutput)
+ case _ => throw new IllegalArgumentException(s"Version
$stateFormatVersion is invalid")
+ }
+ }
+ }
+
+ abstract class StreamingAggregationStateManagerBaseImpl(
+ protected val keyExpressions: Seq[Attribute],
+ protected val childOutput: Seq[Attribute]) extends
StreamingAggregationStateManager {
+
+ @transient protected lazy val keyProjector =
+ GenerateUnsafeProjection.generate(keyExpressions, childOutput)
+
+ def extractKey(row: InternalRow): UnsafeRow = keyProjector(row)
+ }
+
+ class StreamingAggregationStateManagerImplV1(
+ keyExpressions: Seq[Attribute],
+ childOutput: Seq[Attribute])
+ extends StreamingAggregationStateManagerBaseImpl(keyExpressions,
childOutput) {
+
+ override def getValueExpressions: Seq[Attribute] = {
+ childOutput
+ }
+
+ override def restoreOriginRow(rowPair: UnsafeRowPair): UnsafeRow = {
+ rowPair.value
+ }
+
+ override def get(store: StateStore, key: UnsafeRow): UnsafeRow = {
+ store.get(key)
+ }
+
+ override def put(store: StateStore, row: UnsafeRow): Unit = {
+ store.put(extractKey(row), row)
+ }
+ }
+
+ class StreamingAggregationStateManagerImplV2(
--- End diff --
Great point. I might be in a rush to show its shape. Will add doc for state
formats in both V1 and V2.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
