Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21733#discussion_r206780521 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.streaming + +import org.apache.spark.internal.Logging +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.expressions.{Attribute, UnsafeRow} +import org.apache.spark.sql.catalyst.expressions.codegen.{GenerateUnsafeProjection, GenerateUnsafeRowJoiner} +import org.apache.spark.sql.execution.streaming.state.{StateStore, UnsafeRowPair} +import org.apache.spark.sql.types.StructType + +object StatefulOperatorsHelper { + + val supportedVersions = Seq(1, 2) + val legacyVersion = 1 + + sealed trait StreamingAggregationStateManager extends Serializable { + def extractKey(row: InternalRow): UnsafeRow + def getValueExpressions: Seq[Attribute] + def restoreOriginRow(rowPair: UnsafeRowPair): UnsafeRow + def get(store: StateStore, key: UnsafeRow): UnsafeRow --- End diff -- I might think naively about this: I thought its interface is similar to StateStore so wondered we need to add docs, but I think I was wrong. Will add docs. Thanks for the insightful input!
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org