Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21955#discussion_r207394183
--- Diff:
external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/KafkaTestUtils.scala
---
@@ -109,7 +109,7 @@ private[kafka010] class KafkaTestUtils extends Logging {
brokerConf = new KafkaConfig(brokerConfiguration, doLog = false)
server = new KafkaServer(brokerConf)
server.startup()
- brokerPort = server.boundPort()
+ brokerPort = server.boundPort(brokerConf.interBrokerListenerName)
--- End diff --
> @zsxwing comparing to your change... should this be "PLAINTEXT"?
I think both fine.
> default.api.timeout.ms -> 3000
You don't need to add `default.api.timeout.ms` to `brokerConfiguration`.
It's a client configuration. I think you don't need to add this to any place.
DStreams Kafka doesn't have tests requiring this config.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
