Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/21320
  
    > the window of opportunity to review syntax and style in this PR closed 
long ago.
    
    Why/when is this window closed? Who closed that?
    
    This project claims a set of specific styles and they should better be 
fixed if more changes should be fixed. You stated that you refuse to deal with 
non-style comments too, right? For example, enabling the default value to see 
if any test is broken, or getting rid of weird hacks with `withSQL` in the 
tests. These are not style nits. Even, nits should better be addressed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to