Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/3110#discussion_r20049401
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -312,6 +330,17 @@ private[hive] class HiveMetastoreCatalog(hive:
HiveContext) extends Catalog with
override def unregisterAllTables() = {}
}
+private[hive] case class InsertIntoHiveTable(
+ table: LogicalPlan,
+ partition: Map[String, Option[String]],
+ child: LogicalPlan,
+ overwrite: Boolean)
+ extends LogicalPlan {
+
+ override def children = child :: Nil
+ override def output = child.output
+}
--- End diff --
Add a comment to explain the reason that we do not need to override
`resolved`? Also, maybe some comments about this `InsertIntoHiveTable` class?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
