Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/21749
  
    As it's more a cosmetic issue than anything, and reverting the Scala 2.12 
change at least I think will be a problem, I'd suggest not reverting the scala 
version, but instead fixing forward. (Or at least, fix 2.11 but don't revert 
the 2.12 version, and accept that it has an issue.)
    
    I'd love to unify the two Scala REPL source trees even if it costs some 
reflection. The change here looks OK on its surface; does it work?
    
    Did you open another PR where you fully merged the source trees? I swear I 
just saw it last night but can't find the other PR now, if so. That would 
really be the right fix, even if it has to wait until after 2.4, or even after 
the first RC. We still have Scala 2.12 issues in flight that I really want to 
fix for 2.4.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to