Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22210#discussion_r212443117
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java
---
@@ -95,26 +95,24 @@ public ByteBuffer nioByteBuffer() throws IOException {
@Override
public InputStream createInputStream() throws IOException {
FileInputStream is = null;
+ boolean shouldClose = true;
try {
is = new FileInputStream(file);
ByteStreams.skipFully(is, offset);
- return new LimitedInputStream(is, length);
+ InputStream r = new LimitedInputStream(is, length);
+ shouldClose = false;
+ return r;
} catch (IOException e) {
- try {
- if (is != null) {
- long size = file.length();
- throw new IOException("Error in reading " + this + " (actual
file length " + size + ")",
--- End diff --
ditto
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
