Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22210#discussion_r212443039
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java
---
@@ -77,16 +77,16 @@ public ByteBuffer nioByteBuffer() throws IOException {
return channel.map(FileChannel.MapMode.READ_ONLY, offset, length);
}
} catch (IOException e) {
+ String errorMessage = "Error in reading " + this;
try {
if (channel != null) {
long size = channel.size();
- throw new IOException("Error in reading " + this + " (actual
file length " + size + ")",
--- End diff --
This is just thrown and then ignored. I assigned it to `errorMessage` so
that we can see it in the error.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
