Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/21968#discussion_r212896640 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala --- @@ -164,9 +164,8 @@ private[joins] class UnsafeHashedRelation( def getValue(key: InternalRow): InternalRow = { val unsafeKey = key.asInstanceOf[UnsafeRow] val map = binaryMap // avoid the compiler error - val loc = new map.Location // this could be allocated in stack - binaryMap.safeLookup(unsafeKey.getBaseObject, unsafeKey.getBaseOffset, - unsafeKey.getSizeInBytes, loc, unsafeKey.hashCode()) + val loc = map.lookup(unsafeKey.getBaseObject, unsafeKey.getBaseOffset, --- End diff -- this is safe to lookup, and It is different from the get(key: InternalRow).
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org