Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21968#discussion_r212956571
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/RowBasedHashMapGenerator.scala
 ---
    @@ -48,6 +48,8 @@ class RowBasedHashMapGenerator(
         val keySchema = ctx.addReferenceObj("keySchemaTerm", groupingKeySchema)
         val valueSchema = ctx.addReferenceObj("valueSchemaTerm", bufferSchema)
     
    +    val numVarLenFields = 
groupingKeys.map(_.dataType).count(!UnsafeRow.isFixedLength(_))
    --- End diff --
    
    Do not remove the `TODO` comment below.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to