Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20637#discussion_r213556478
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
 ---
    @@ -35,6 +35,24 @@ class ExpressionEvalHelperSuite extends SparkFunSuite 
with ExpressionEvalHelper
         val e = intercept[RuntimeException] { 
checkEvaluation(BadCodegenExpression(), 10) }
         assert(e.getMessage.contains("some_variable"))
       }
    +
    +  test("SPARK-23466: checkEvaluationWithUnsafeProjection should fail if 
null is compared with " +
    --- End diff --
    
    what is this test doing? Let the test framework discover wrongly written 
test cases?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to