Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r213884870
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelperSuite.scala
---
@@ -35,6 +35,24 @@ class ExpressionEvalHelperSuite extends SparkFunSuite
with ExpressionEvalHelper
val e = intercept[RuntimeException] {
checkEvaluation(BadCodegenExpression(), 10) }
assert(e.getMessage.contains("some_variable"))
}
+
+ test("SPARK-23466: checkEvaluationWithUnsafeProjection should fail if
null is compared with " +
--- End diff --
is this necessary? It looks to me that this is a malformed test case: you
are putting a wrong expected value.
It's good to improve the test framework to detect this kind of wrongly
written tests, but I don't think we have to do it now.
Another topic is, when the nullability doesn't match the data, how Spark
should detect it. This is a different story and we can investigate later.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
