Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22282#discussion_r214075761 --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java --- @@ -473,17 +474,6 @@ public static UnsafeArrayData fromPrimitiveArray( return result; } - public static UnsafeArrayData forPrimitiveArray(int offset, int length, int elementSize) { - return fromPrimitiveArray(null, offset, length, elementSize); - } - - public static boolean shouldUseGenericArrayData(int elementSize, int length) { --- End diff -- I think `shouldUseGenericArrayData` is still used in generated code, check the code here: https://github.com/apache/spark/blob/b459cf3f391d6e4ee9cb77a7b5ed510d027d9ddd/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala#L3633
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org