Github user xuanyuanking commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22282#discussion_r214084903
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
 ---
    @@ -473,17 +474,6 @@ public static UnsafeArrayData fromPrimitiveArray(
         return result;
       }
     
    -  public static UnsafeArrayData forPrimitiveArray(int offset, int length, 
int elementSize) {
    -    return fromPrimitiveArray(null, offset, length, elementSize);
    -  }
    -
    -  public static boolean shouldUseGenericArrayData(int elementSize, int 
length) {
    --- End diff --
    
    Yep, the UT failed log proved 
this:https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95468/testReport/org.apache.spark.sql.catalyst.expressions/CollectionExpressionsSuite/Array_Union/


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to