Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22298#discussion_r214405118
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
 ---
    @@ -58,6 +58,15 @@ private[spark] class BasicExecutorFeatureStep(
           (kubernetesConf.get(MEMORY_OVERHEAD_FACTOR) * 
executorMemoryMiB).toInt,
           MEMORY_OVERHEAD_MIN_MIB))
       private val executorMemoryWithOverhead = executorMemoryMiB + 
memoryOverheadMiB
    +  // TODO: Have memory limit checks on executorMemory
    --- End diff --
    
    Same as other TODO


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to