Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22298#discussion_r214406804
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/JavaDriverFeatureStep.scala
 ---
    @@ -38,7 +39,8 @@ private[spark] class JavaDriverFeatureStep(
           .build()
         SparkPod(pod.pod, withDriverArgs)
       }
    -  override def getAdditionalPodSystemProperties(): Map[String, String] = 
Map.empty
    +  override def getAdditionalPodSystemProperties(): Map[String, String] =
    --- End diff --
    
    So is this going to override it if the user wants to set a different type 
even if they are ostensibly running a JVM pod (e.g. mixed language pipelines).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to