Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22165#discussion_r215324595
  
    --- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
    @@ -65,7 +65,7 @@ private[spark] class BarrierCoordinator(
     
       // Record all active stage attempts that make barrier() call(s), and the 
corresponding internal
       // state.
    -  private val states = new ConcurrentHashMap[ContextBarrierId, 
ContextBarrierState]
    +  private[spark] val states = new ConcurrentHashMap[ContextBarrierId, 
ContextBarrierState]
    --- End diff --
    
    Could you turn the `// ...` comment into ScalaDoc `/** ... */` and mention 
`Visible for unit testing.` in the doc?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to