Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22165#discussion_r215636283
--- Diff: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala ---
@@ -187,6 +191,9 @@ private[spark] class BarrierCoordinator(
requesters.clear()
cancelTimerTask()
}
+
+ // Check for clearing internal data, visible for test only.
+ private[spark] def cleanCheck(): Boolean = requesters.isEmpty &&
timerTask == null
--- End diff --
Add internal data clean check in Xingbo's comments:
https://github.com/apache/spark/pull/22165#issuecomment-415086679.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
