Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r215469488
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadoopsteps/HadoopKerberosKeytabResolverStep.scala
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.k8s.features.hadoopsteps
+
+import java.io._
+import java.security.PrivilegedExceptionAction
+
+import scala.collection.JavaConverters._
+
+import io.fabric8.kubernetes.api.model.SecretBuilder
+import org.apache.commons.codec.binary.Base64
+
+import org.apache.spark.{SparkConf, SparkException}
+import org.apache.spark.deploy.SparkHadoopUtil
+import org.apache.spark.deploy.k8s.Constants._
+import
org.apache.spark.deploy.k8s.security.KubernetesHadoopDelegationTokenManager
+import org.apache.spark.deploy.security.HadoopDelegationTokenManager
+import org.apache.spark.internal.Logging
+
+ /**
+ * This step does all the heavy lifting for Delegation Token logic. This
step
+ * assumes that the job user has either specified a principal and keytab
or ran
+ * $kinit before running spark-submit. With a TGT stored locally, by
running
+ * UGI.getCurrentUser you are able to obtain the current user,
alternatively
+ * you can run UGI.loginUserFromKeytabAndReturnUGI and by running .doAs
run
+ * as the logged into user instead of the current user. With the Job User
principal
+ * you then retrieve the delegation token from the NameNode and store
values in
+ * DelegationToken. Lastly, the class puts the data into a secret. All
this is
+ * appended to the current HadoopSpec which in turn will append to the
current
+ * DriverSpec.
+ */
+private[spark] class HadoopKerberosKeytabResolverStep(
+ submissionSparkConf: SparkConf,
+ kubernetesResourceNamePrefix : String,
+ maybePrincipal: Option[String],
+ maybeKeytab: Option[File],
+ maybeRenewerPrincipal: Option[String],
+ tokenManager: KubernetesHadoopDelegationTokenManager)
+ extends HadoopConfigurationStep with Logging {
+
+ override def configureHadoopSpec(hSpec: HadoopConfigSpec):
HadoopConfigSpec = {
+ val hadoopConf =
SparkHadoopUtil.get.newConfiguration(submissionSparkConf)
+ if (!tokenManager.isSecurityEnabled) {
+ throw new SparkException("Hadoop not configured with Kerberos")
+ }
+ val maybeJobUserUGI =
--- End diff --
Shouldn't the `yarn` config change exist in a different PR or should I
include it in here?
I agree that it would be super helpful.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
