Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r215471255
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala
---
@@ -60,7 +62,23 @@ private[spark] case class KubernetesConf[T <:
KubernetesRoleSpecificConf](
roleSecretEnvNamesToKeyRefs: Map[String, String],
roleEnvs: Map[String, String],
roleVolumes: Iterable[KubernetesVolumeSpec[_ <:
KubernetesVolumeSpecificConf]],
- sparkFiles: Seq[String]) {
+ sparkFiles: Seq[String],
+ hadoopConfDir: Option[String]) {
+
+ def getHadoopConfigMapName: String =
s"$appResourceNamePrefix-hadoop-config"
+
+ def getKRBConfigMapName: String = s"$appResourceNamePrefix-krb5-file"
+
+ def getHadoopStepsOrchestrator : Option[HadoopStepsOrchestrator] =
hadoopConfDir.map {
+ hConf => new HadoopStepsOrchestrator(
+ sparkConf,
+ appResourceNamePrefix,
+ hConf,
+ getHadoopConfigMapName,
+ getTokenManager.isSecurityEnabled)}
+
+ def getTokenManager : KubernetesHadoopDelegationTokenManager =
--- End diff --
The `KubernetesHadoopDelegationTokenManager` is crucial for doing token
retrieval and needs to be done in the Feature steps. As such, must be retrieved
via the `KubernetesConf`. Sadly, I don't see another way given the design of
the feature steps.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
