Github user NiharS commented on a diff in the pull request:
https://github.com/apache/spark/pull/22192#discussion_r215760787
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -218,6 +244,8 @@ private[spark] class Executor(
env.metricsSystem.report()
heartbeater.shutdown()
heartbeater.awaitTermination(10, TimeUnit.SECONDS)
+ executorPluginThread.interrupt()
+ executorPluginThread.join()
--- End diff --
Oops, yeah, my bad. I believe the current implementation also terminates
the plugins immediately...
For your recommendation, would the thread that initializes the plugins also
be undergoing the conditional wait? If so, would that mean I cannot join on
this thread right after initialization of plugins (from your earlier comment)
since the thread would stay alive to wait for the shutdown condition?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
