Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22192#discussion_r216049530
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -219,6 +236,13 @@ private[spark] class Executor(
heartbeater.shutdown()
heartbeater.awaitTermination(10, TimeUnit.SECONDS)
threadPool.shutdown()
+
+ // Notify plugins that executor is shutting down so they can terminate
cleanly
+ // oldContextClassLoader is redefined in case the class loader changed
during execution
+ val oldContextClassLoader = Utils.getContextOrSparkClassLoader
--- End diff --
I think it's worth it to add a method in `Utils.scala` to do the class
loader thingy. This code pattern is used in a bunch of places, it would be nice
to make it easier (and later change existing code to use the new method).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
