Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3204#discussion_r20137693
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -217,14 +223,24 @@ private[spark] class ExecutorAllocationManager(sc: 
SparkContext) extends Logging
           numExecutorsToAdd = 1
           return 0
         }
    +    val maxExecutorsPending = 
maxPendingExecutors(sc.taskScheduler.numPendingTasks)
    --- End diff --
    
    I noticed that, but couldn't figure out a better way to pass this through 
information through.  `SparkListener` can give us the total pending tasks at 
the start of a stage, but, as far as I could tell, only the TaskSetManagers 
know the pending tasks as a stage progresses.  Reconstituting this info from 
onTaskStart and onTaskEnd events isn't easy because tasks can need to be 
resubmitted.  Am I missing anything?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to