Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3204#discussion_r20170257
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -110,6 +110,12 @@ private[spark] class ExecutorAllocationManager(sc:
SparkContext) extends Logging
// Clock used to schedule when executors should be added and removed
private var clock: Clock = new RealClock
+ // TODO: The default value of 1 for spark.executor.cores works right now
because dynamic
+ // allocation is only supported for YARN and the default number of cores
per executor in YARN is
+ // 1, but it might need to be attained differently for different cluster
managers
+ private val tasksPerExecutor =
+ conf.getInt("spark.executor.cores", 1) /
conf.getInt("spark.task.cpus", 1)
--- End diff --
This could become 0 if `spark.task.cpus` > `spark.executor.cores`, and
you're dividing by this later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
