Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22270#discussion_r215869136
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
    @@ -1729,10 +1730,8 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
       }
     
       test("SPARK-9083: sort with non-deterministic expressions") {
    -    import org.apache.spark.util.random.XORShiftRandom
    -
         val seed = 33
    -    val df = (1 to 100).map(Tuple1.apply).toDF("i")
    +    val df = (1 to 100).map(Tuple1.apply).toDF("i").repartition(1)
    --- End diff --
    
    Sorry I didn't follow this thread closely. Why do we need these 
repartition(1) changes?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to