Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22270#discussion_r216198738
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -85,14 +85,16 @@ class DataFrameFunctionsSuite extends QueryTest with
SharedSQLContext {
}
val df5 = Seq((Seq("a", null), Seq(1, 2))).toDF("k", "v")
- intercept[RuntimeException] {
+ val msg1 = intercept[Exception] {
--- End diff --
@HyukjinKwon Yeah... we could have caught SparkException here. My intention
was to have this test case pass both when location relation optimization is on
and off. Thats why i changed it a a generic exception along with verifying the
error text.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
