Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22192#discussion_r216106374
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -136,6 +136,26 @@ private[spark] class Executor(
       // for fetching remote cached RDD blocks, so need to make sure it uses 
the right classloader too.
       env.serializerManager.setDefaultClassLoader(replClassLoader)
     
    +  private val plugins: Seq[ExecutorPlugin] = {
    +    val pluginNames = conf.get(EXECUTOR_PLUGINS)
    +    if (pluginNames.nonEmpty) {
    +      logDebug(s"Initializing the following plugins: 
${pluginNames.mkString(", ")}")
    +
    +      // Before loading the executor plugins, we need to temporarily 
change the class loader
    --- End diff --
    
    This comment is actually not currently accurate unless you're running YARN. 
In this context, it should mention the "executor's user classpath", not how 
it's formed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to