GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22361
Revert [SPARK-10399] [SPARK-23879] [SPARK-23762]
## What changes were proposed in this pull request?
When running TPC-DS benchmarks on 2.4 release, we saw more than 10%
performance regression on the following queries: q67, q24a and q24b. After we
applying the PR https://github.com/apache/spark/pull/22338, the performance
regression still exists. If we revert the changes in
https://github.com/apache/spark/pull/19222, we found the performance regression
was resolved. Thus, this PR is to revert the related changes for unblocking the
2.4 release.
In the future release, we still can continue the investigation and find out
the root cause of the regression.
## How was this patch tested?
The existing test cases
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark revertMemoryBlock
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22361.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22361
----
commit 711963a98d4a46399f95b1969b7b952ae8866c52
Author: gatorsmile <gatorsmile@...>
Date: 2018-09-07T17:38:52Z
Revert "[SPARK-10399][SPARK-23879][FOLLOWUP][CORE] Free unused off-heap
memory in MemoryBlockSuite"
This reverts commit c3a86faa53c9e49efd595802adc38a6d412ce681.
commit 0504f08b671b114834f6fb5a879de62c2992421d
Author: gatorsmile <gatorsmile@...>
Date: 2018-09-07T17:39:27Z
Revert "[SPARK-10399][SPARK-23879][HOTFIX] Fix Java lint errors"
This reverts commit b6935ffb4dfb1d9fdf36ba402ac07bd02978c012.
commit ca179acac2acd595a6062a86d05f9c2d9f0be6d2
Author: gatorsmile <gatorsmile@...>
Date: 2018-09-07T18:42:33Z
Revert "[SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks to choose
several types of memory block"
This reverts commit 4807d381bb113a5c61e6dad88202f23a8b6dd141.
commit cbe3a514e3bdc47a1fedb49695f65bb378fc57cb
Author: gatorsmile <gatorsmile@...>
Date: 2018-09-07T18:42:52Z
Revert "[SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock"
This reverts commit 0b19122d434e39eb117ccc3174a0688c9c874d48.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
