Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3009#discussion_r20189716
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala
---
@@ -41,11 +41,13 @@ private[ui] class JobProgressPage(parent:
JobProgressTab) extends WebUIPage("")
val activeStagesTable =
new StageTableBase(activeStages.sortBy(_.submissionTime).reverse,
- parent, parent.killEnabled)
+ parent.basePath, parent.listener, parent.killEnabled)
val completedStagesTable =
- new
StageTableBase(completedStages.sortBy(_.submissionTime).reverse, parent)
+ new
StageTableBase(completedStages.sortBy(_.submissionTime).reverse,
parent.basePath,
+ parent.listener, parent.killEnabled)
--- End diff --
This is a good catch. It turns out that this was a pretty serious mistake,
since the `parent.killEnabled` that i'm passing here was actually being used
for the `isFairScheduler` boolean. I've explicitly named my boolean parameters
to avoid this sort of mistake. I've also added a Selenium test to catch these
sorts of regressions where `spark.ui.killEnabled` isn't respected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
