Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22355#discussion_r217233868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -37,19 +37,22 @@ object CodegenObjectFactoryMode extends Enumeration {
*/
abstract class CodeGeneratorWithInterpretedFallback[IN, OUT] extends
Logging {
- def createObject(in: IN): OUT = {
+ def createObject(in: IN): OUT =
+ createObject(in, subexpressionEliminationEnabled = false)
--- End diff --
can we do that first? I think that will be a small change and can also make
this PR simpler and easier to review.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
