Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22355#discussion_r217241810
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -37,19 +37,22 @@ object CodegenObjectFactoryMode extends Enumeration {
*/
abstract class CodeGeneratorWithInterpretedFallback[IN, OUT] extends
Logging {
- def createObject(in: IN): OUT = {
+ def createObject(in: IN): OUT =
+ createObject(in, subexpressionEliminationEnabled = false)
--- End diff --
I took some more look, seems it's not an actual config, but just a method
parameter. Maybe we should remove this config in 3.0.
that said, let's keep your PR as it is.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
