Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r218000572
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
---
@@ -595,10 +607,7 @@ case class JsonToStructs(
if (json.toString.trim.isEmpty) return null
try {
- converter(parser.parse(
- json.asInstanceOf[UTF8String],
- CreateJacksonParser.utf8String,
- identity[UTF8String]))
+ converter(parser.parse(json.asInstanceOf[UTF8String]))
} catch {
case _: BadRecordException => null
--- End diff --
Do we still need this catching of `BadRecordException`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
