Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r217995920
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala
---
@@ -402,13 +402,13 @@ class JsonExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper with
val schema = StructType(StructField("a", IntegerType) :: Nil)
checkEvaluation(
JsonToStructs(schema, Map.empty, Literal(jsonData), gmtId),
- null
+ InternalRow(null)
)
// Other modes should still return `null`.
checkEvaluation(
JsonToStructs(schema, Map("mode" -> PermissiveMode.name),
Literal(jsonData), gmtId),
--- End diff --
The default mode is `PermissiveMode` now, so this looks necessary to change.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
