Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22452#discussion_r218496943
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/python/PythonForeachWriterSuite.scala
---
@@ -75,15 +78,20 @@ class PythonForeachWriterSuite extends SparkFunSuite
with Eventually {
tester = new BufferTester(memBytes, sleepPerRowReadMs)
f(tester)
} finally {
- if (tester == null) tester.close()
+ if (tester != null) tester.close()
--- End diff --
yes, but that NPE just covered up another NPE from
`SparkEnv.get.serializerManager`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
