Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16677#discussion_r218630488
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
    @@ -557,11 +557,13 @@ class DataFrameAggregateSuite extends QueryTest with 
SharedSQLContext {
       }
     
       test("SPARK-18004 limit + aggregates") {
    -    val df = Seq(("a", 1), ("b", 2), ("c", 1), ("d", 5)).toDF("id", 
"value")
    -    val limit2Df = df.limit(2)
    -    checkAnswer(
    -      limit2Df.groupBy("id").count().select($"id"),
    -      limit2Df.select($"id"))
    +    withSQLConf(SQLConf.LIMIT_FLAT_GLOBAL_LIMIT.key -> "true") {
    --- End diff --
    
    why do we set this flag here? we need to document it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to