Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16677#discussion_r218630513
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/PruningSuite.scala 
---
    @@ -22,21 +22,29 @@ import scala.collection.JavaConverters._
     import org.scalatest.BeforeAndAfter
     
     import org.apache.spark.sql.hive.test.{TestHive, TestHiveQueryExecution}
    +import org.apache.spark.sql.internal.SQLConf
     
     /**
      * A set of test cases that validate partition and column pruning.
      */
     class PruningSuite extends HiveComparisonTest with BeforeAndAfter {
     
    +  private val originalLimitFlatGlobalLimit = 
TestHive.conf.limitFlatGlobalLimit
    +
       override def beforeAll(): Unit = {
         super.beforeAll()
         TestHive.setCacheTables(false)
    +    TestHive.setConf(SQLConf.LIMIT_FLAT_GLOBAL_LIMIT, false)
    --- End diff --
    
    why do we set this flag here? we need to document it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to