Github user ksakellis commented on a diff in the pull request:
https://github.com/apache/spark/pull/3120#discussion_r20248211
--- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
@@ -252,7 +258,7 @@ class HadoopRDD[K, V](
&& bytesReadCallback.isDefined) {
recordsSinceMetricsUpdate = 0
val bytesReadFn = bytesReadCallback.get
- inputMetrics.bytesRead = bytesReadFn()
+ inputMetrics.bytesRead = bytesReadFn() + bytesReadAtStart
--- End diff --
So BytesReadFn() doesn't return the incremental bytes read. It returns the
total bytes read since the callback was created. This is why we just keep
re-assigning the inputMetrics.bytesRead variable to bytesReadFn() + our
starting amount. If we want to keep adding the incremental amount read, then
we'd need to do some bookkeeping with how many bytes we read in. This was my
original solution but made the code even harder to follow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
