Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/3120#discussion_r20263076 --- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala --- @@ -252,7 +258,7 @@ class HadoopRDD[K, V]( && bytesReadCallback.isDefined) { recordsSinceMetricsUpdate = 0 val bytesReadFn = bytesReadCallback.get - inputMetrics.bytesRead = bytesReadFn() + inputMetrics.bytesRead = bytesReadFn() + bytesReadAtStart --- End diff -- I know there were elegance reasons for why we initially rejected an approach that registers a bytesReadFn with the task (metrics) itself, but now that I'm aware that certain operations interleave reads in this way, it seems like that might be a better option?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org