Github user shahidki31 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22645#discussion_r223174634
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/PagedTable.scala ---
    @@ -31,7 +31,7 @@ import org.apache.spark.util.Utils
      *
      * @param pageSize the number of rows in a page
      */
    -private[ui] abstract class PagedDataSource[T](val pageSize: Int) {
    +private[spark] abstract class PagedDataSource[T](val pageSize: Int) {
    --- End diff --
    
    Hi @felixcheung , Thanks for the review.
     'AllExecutionsPage'  and 'PagedTable' are in different packages. Currently 
PagedTable is not accessible to the AllExecutionsPage class. 
    Also excpet 'PagedTable', all the classes in the core ui are open to the 
spark level, like 'JettyUtils', 'SparkUI', 'UIUtils', 'WebUI' etc. 
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to