Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22645#discussion_r223188217
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
---
@@ -202,100 +385,127 @@ private[ui] abstract class ExecutionTable(
</td>
}}
{if (showSucceededJobs) {
- <td>
- {jobLinks(JobExecutionStatus.SUCCEEDED)}
- </td>
- }}
+ <td>
+ {jobLinks(JobExecutionStatus.SUCCEEDED)}
+ </td>
+ }}
{if (showFailedJobs) {
- <td>
- {jobLinks(JobExecutionStatus.FAILED)}
- </td>
- }}
+ <td>
+ {jobLinks(JobExecutionStatus.FAILED)}
+ </td>
+ }}
</tr>
}
- private def descriptionCell(
- request: HttpServletRequest,
- execution: SQLExecutionUIData): Seq[Node] = {
+ private def descriptionCell(execution: SQLExecutionUIData): Seq[Node] = {
val details = if (execution.details != null &&
execution.details.nonEmpty) {
- <span onclick="clickDetail(this)" class="expand-details">
+ <span onclick="this.parentNode.querySelector('.stage-details').
+ classList.toggle('collapsed')"
+ class="expand-details">
+details
</span> ++
- <div class="stage-details collapsed">
- <pre>{execution.details}</pre>
- </div>
+ <div class="stage-details collapsed">
--- End diff --
I believe this shouldn't be indented more
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
