Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22630#discussion_r223277348
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -360,6 +360,10 @@ trait CodegenSupport extends SparkPlan {
* limit-not-reached checks.
*/
final def limitNotReachedCond: String = {
+ // InputAdapter is also a leaf node.
+ val isLeafNode = children.isEmpty || this.isInstanceOf[InputAdapter]
+ assert(isLeafNode || this.isInstanceOf[BlockingOperatorWithCodegen],
--- End diff --
nit: shall we do this only if `Utils.isTesting` and otherwise just emit a
warning maybe?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
