Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22630#discussion_r223318798
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -362,8 +362,15 @@ trait CodegenSupport extends SparkPlan {
final def limitNotReachedCond: String = {
// InputAdapter is also a leaf node.
val isLeafNode = children.isEmpty || this.isInstanceOf[InputAdapter]
- assert(isLeafNode || this.isInstanceOf[BlockingOperatorWithCodegen],
- "only leaf nodes and blocking nodes need to call this method in its
data producing loop.")
+ if (isLeafNode || this.isInstanceOf[BlockingOperatorWithCodegen]) {
--- End diff --
`if (!isLeafNode && !this.isInstanceOf[BlockingOperatorWithCodegen])`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
