Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22671#discussion_r223752722
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -332,7 +332,9 @@ class KafkaSinkSuite extends StreamTest with
SharedSQLContext with KafkaTest {
var ex: Exception = null
try {
ex = intercept[StreamingQueryException] {
- writer = createKafkaWriter(input.toDF(), withTopic = Some(topic))()
+ writer = createKafkaWriter(input.toDF(),
--- End diff --
Can we set this inside `createKafkaWriter`? it seems like it's a generally
good idea to not let anything block that long in tests. In fact
KafkaContinuousSinkSuite sets it to 1000. We should standardize that too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
